Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] load list of slices at modal enter time #3379

Merged
merged 1 commit into from
Aug 28, 2017
Merged

[dashboard] load list of slices at modal enter time #3379

merged 1 commit into from
Aug 28, 2017

Conversation

mistercrunch
Copy link
Member

Saving an async request on every dashboard load

@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.287% when pulling 7a4db84b64107f3cd9b84ea0f33adee1b3bd8266 on mistercrunch:dash_opt into 2d237fe on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.287% when pulling 7a4db84b64107f3cd9b84ea0f33adee1b3bd8266 on mistercrunch:dash_opt into 2d237fe on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.287% when pulling 82a5dc6ea9421a20cfeb6ef9b13ff6079274a204 on mistercrunch:dash_opt into aff7a82 on apache:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.287% when pulling 82a5dc6ea9421a20cfeb6ef9b13ff6079274a204 on mistercrunch:dash_opt into aff7a82 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.287% when pulling 82a5dc6ea9421a20cfeb6ef9b13ff6079274a204 on mistercrunch:dash_opt into aff7a82 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.287% when pulling 82a5dc6ea9421a20cfeb6ef9b13ff6079274a204 on mistercrunch:dash_opt into aff7a82 on apache:master.

@coveralls
Copy link

coveralls commented Aug 28, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.321% when pulling 2765e61 on mistercrunch:dash_opt into a47a512 on apache:master.

@graceguo-supercat
Copy link

LGTM

@mistercrunch mistercrunch merged commit 48b88e5 into apache:master Aug 28, 2017
@mistercrunch mistercrunch deleted the dash_opt branch August 28, 2017 21:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @coveralls @graceguo-supercat