-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sql lab] fix encoding error in logging message #3424
[sql lab] fix encoding error in logging message #3424
Conversation
875ce21
to
7ad234a
Compare
Coverage decreased (-0.2%) to 68.9% when pulling 7ad234ab6e2717db82ed30dc32676af8a7534d53 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master. |
Coverage decreased (-0.2%) to 68.9% when pulling 7ad234ab6e2717db82ed30dc32676af8a7534d53 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master. |
7ad234a
to
d8a769f
Compare
Coverage decreased (-0.2%) to 68.961% when pulling d8a769fc3dec5e74624ae62a5da266dbcba1b247 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master. |
d8a769f
to
b27b5bf
Compare
Coverage decreased (-0.2%) to 68.961% when pulling b27b5bf70dbfbaa2ad0fe919abca2f3a88172ce5 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master. |
1 similar comment
Coverage decreased (-0.2%) to 68.961% when pulling b27b5bf70dbfbaa2ad0fe919abca2f3a88172ce5 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master. |
b2075e8
to
786b12f
Compare
Coverage increased (+0.005%) to 69.123% when pulling 786b12ff28c1bf40312f430d907cb856619d3ae3 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> dedup(['foo', 'bar', 'bar', 'bar'])
to
>>> len(dedup(['foo', 'bar', 'bar', 'bar']))
4
786b12f
to
b8b5ea9
Compare
Coverage decreased (-0.2%) to 68.962% when pulling b8b5ea9122a7c186dc3ce54a545097e180e3a00f on graceguo-supercat:gg-SQLlabEncoding into 8223729 on apache:master. |
b8b5ea9
to
eeb6b86
Compare
In Sql Lab, user types in a query with unicode like this:
SELECT * FROM "tb_name" WHERE city = "Lübeck"
When sql_parse.py and sql_lab.py tried to log message like:
logging.info("Parsing with sqlparse statement {}".format(self.sql))
This cause exception thrown, and user got Internal Server Error from Sql Lab.