Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Support for libsodium >= 1.0.17 in Apache Tuweni #163

Closed
r-peter opened this issue Nov 8, 2020 · 5 comments
Closed

Support for libsodium >= 1.0.17 in Apache Tuweni #163

r-peter opened this issue Nov 8, 2020 · 5 comments
Milestone

Comments

@r-peter
Copy link

r-peter commented Nov 8, 2020

Tuweni (1.2.0) has support up to Libsodium 1.0.16. Libsodium has newer versions available - 1.0.17 and higher.
https://github.com/jedisct1/libsodium/blob/master/ChangeLog

It would be nice to have support for newer versions of Libsodium also.

Related discussion thread is here:
https://mail-archives.apache.org/mod_mbox/tuweni-users/202011.mbox/%3cCAEShzP57Eu1U7EHSmUFHk+VfoMYc2sosVxvQ7x8bMcdXFQqUkQ@mail.gmail.com%3e

@atoulme
Copy link
Member

atoulme commented Nov 11, 2020

We generate the sodium sources by applying this python script to the sodium header file:
https://gist.github.com/atoulme/d37e62545c68dcddd389f284f779311e

@atoulme
Copy link
Member

atoulme commented Nov 12, 2020

@r-peter do you want to take a look at the PR?

@r-peter
Copy link
Author

r-peter commented Nov 13, 2020

Thank you so much @atoulme for incorporating the changes very quickly. The changes look good to me. I am building my solution using the SNAPSHOT I have created from your feature branch.
I observed failure of 2 test cases on my Windows machine. I can open another issue to report it to the team as it is not related to the changes made in this branch.

@atoulme
Copy link
Member

atoulme commented Nov 13, 2020 via email

@atoulme atoulme added this to the 1.3.0 milestone Nov 14, 2020
@atoulme
Copy link
Member

atoulme commented Nov 14, 2020

#167 fixes the Windows issue. Closing.

@atoulme atoulme closed this as completed Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants