This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Support for libsodium >= 1.0.17 in Apache Tuweni #163
Milestone
Comments
We generate the sodium sources by applying this python script to the sodium header file: |
Merged
@r-peter do you want to take a look at the PR? |
Thank you so much @atoulme for incorporating the changes very quickly. The changes look good to me. I am building my solution using the SNAPSHOT I have created from your feature branch. |
Please do open another issue. I don’t have a Windows dev box but we can start testing with GitHub actions if that helps.
… On Nov 12, 2020, at 17:01, r-peter ***@***.***> wrote:
Thank you so much @atoulme for incorporating the changes very quickly. The changes look good to me. I am building my solution using the SNAPSHOT I have created from your feature branch.
I observed failure of 2 test cases on my Windows machine. I can open another issue to report it to the team as it is not related to the changes made in this branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
#167 fixes the Windows issue. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Tuweni (1.2.0) has support up to Libsodium 1.0.16. Libsodium has newer versions available - 1.0.17 and higher.
https://github.com/jedisct1/libsodium/blob/master/ChangeLog
It would be nice to have support for newer versions of Libsodium also.
Related discussion thread is here:
https://mail-archives.apache.org/mod_mbox/tuweni-users/202011.mbox/%3cCAEShzP57Eu1U7EHSmUFHk+VfoMYc2sosVxvQ7x8bMcdXFQqUkQ@mail.gmail.com%3e
The text was updated successfully, but these errors were encountered: