[Topi]Allow empty tensor for reshape, tile and strided_slice #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
reviewed
Jan 4, 2020
topi/python/topi/util.py
Outdated
| is_empty: bool | ||
| Whether input shape is empty or has dimesion with size 0. | ||
| """ | ||
| is_empty = False |
There was a problem hiding this comment.
equivalent to the following (same for C++ code) ?
for dim in shape:
if isinstance(dim, tvm.expr.IntImm):
if dim.value == 0:
return True
return False
zhiics
approved these changes
Jan 6, 2020
|
Thanks @kevinthesun @yongwww |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
…4618) * Support empty tensor * Fix schedule * Refactor * Minor fix * Fix pylint * Merge cpp and python is_empty_shape
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
…4618) * Support empty tensor * Fix schedule * Refactor * Minor fix * Fix pylint * Merge cpp and python is_empty_shape
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
…4618) * Support empty tensor * Fix schedule * Refactor * Minor fix * Fix pylint * Merge cpp and python is_empty_shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some reshape, tile and strided_slice ops can generate empty tensor(tensor shape such as (4, 0, 2)) in some tensorflow models. This PR adds support in topi.
@zhiics @yongwww