Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Frontend][TFlite] Add parses support for unary elemwise ops #4634

Merged
merged 3 commits into from
Jan 9, 2020
Merged

[Relay][Frontend][TFlite] Add parses support for unary elemwise ops #4634

merged 3 commits into from
Jan 9, 2020

Conversation

inadob
Copy link
Contributor

@inadob inadob commented Jan 6, 2020

  • Add generic method to convert unary math functions
  • Add support for: abs, exp, ceil, floor, log, sin, cos, sqrt, rsqrt, neg
  • Add relevant tests

@inadob
[Relay][Frontend][Tflite] Add parses support for unary elemwise ops
c73b129 
* Add generic method to convert unary functions: abs, exp, ceil, floor
  log, sin, cos, sqrt, rsqrt, neg
* Add relevant tests
@inadob inadob changed the title [Relay][Frontend][Tflite] Add parses support for unary elemwise ops [Relay][Frontend][TFlite] Add parses support for unary elemwise ops Jan 6, 2020
@inadob
Copy link
Contributor Author

inadob commented Jan 6, 2020

@kevinthesun @FrozenGene can you please review this patch

anijain2305
anijain2305 approved these changes Jan 6, 2020
View reviewed changes
tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented Jan 6, 2020 •
edited
Loading

ping @FrozenGene @kazum please also take a look

FrozenGene
FrozenGene approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@FrozenGene FrozenGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minimal code style comment.

tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
@tqchen tqchen merged commit 7a30e5f into apache:master Jan 9, 2020
@tqchen
Copy link
Member

tqchen commented Jan 9, 2020

Thanks @FrozenGene @anijain2305 @inadob

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@inadob @alexwong
[Relay][Frontend][TFlite] Add parses support for unary elemwise ops (a…
565b22c 
…pache#4634)

* [Relay][Frontend][Tflite] Add parses support for unary elemwise ops

* Add generic method to convert unary functions: abs, exp, ceil, floor
  log, sin, cos, sqrt, rsqrt, neg
* Add relevant tests

* Delete excessive underscores as requested in PR review

* Change parameter name as suggested in PR review
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@inadob @alexwong
[Relay][Frontend][TFlite] Add parses support for unary elemwise ops (a…
444ee5e 
…pache#4634)

* [Relay][Frontend][Tflite] Add parses support for unary elemwise ops

* Add generic method to convert unary functions: abs, exp, ceil, floor
  log, sin, cos, sqrt, rsqrt, neg
* Add relevant tests

* Delete excessive underscores as requested in PR review

* Change parameter name as suggested in PR review
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@inadob @zhiics
[Relay][Frontend][TFlite] Add parses support for unary elemwise ops (a…
e87c655 
…pache#4634)

* [Relay][Frontend][Tflite] Add parses support for unary elemwise ops

* Add generic method to convert unary functions: abs, exp, ceil, floor
  log, sin, cos, sqrt, rsqrt, neg
* Add relevant tests

* Delete excessive underscores as requested in PR review

* Change parameter name as suggested in PR review
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrozenGene FrozenGene FrozenGene approved these changes

@tqchen tqchen tqchen approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

Assignees

@kazum kazum

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inadob @tqchen @FrozenGene @anijain2305 @kazum