[Relay][Frontend][TFLite] Add constant input support for elemwise ops #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please request reviews by at reviewers |
|
Could you check this PR, @kevinthesun @FrozenGene |
FrozenGene
approved these changes
Jan 15, 2020
tqchen
approved these changes
Jan 15, 2020
|
Thanks @wyc-ruiker @FrozenGene |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
…apache#4666) * [Relay][Frontend][TFLite] Add constant input support for elemwise ops * modify in tflite.py
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
…apache#4666) * [Relay][Frontend][TFLite] Add constant input support for elemwise ops * modify in tflite.py
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
…apache#4666) * [Relay][Frontend][TFLite] Add constant input support for elemwise ops * modify in tflite.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFLite elementwise ops (like
ADD,MUL, etc.) only supportrhs_expris a constant value. Butlhs_exprcan also be a constant value.In fact, the other ops like
RESHAPEcan also have a constant value as input. But there are too many cases to be modified. We need more discuss forin_expr = self.get_expr(input_tensor_idx)in every operator.