Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Frontend][TF] fix _parse_param bug #4711

Merged
merged 1 commit into from
Jan 15, 2020
Merged

[Relay][Frontend][TF] fix _parse_param bug #4711

merged 1 commit into from
Jan 15, 2020

Conversation

fwd4
Copy link
Contributor

@fwd4 fwd4 commented Jan 15, 2020

  • fix parsing bug that DT_STRING Const name might not be defined in shape dictionary specified in from_tensorflow parameter
  • update test case

@fwd4 fwd4 requested a review from kevinthesun January 15, 2020 04:53
cchung100m
cchung100m approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

kevinthesun
kevinthesun approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit 02c6767 into apache:master Jan 15, 2020
@kevinthesun
Copy link
Contributor

Thanks @LiangHao151941 @cchung100m

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@fwd4 @alexwong
[Relay][Frontend][TF] fix _parse_param bug (apache#4711)
89a1c5a
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@fwd4 @alexwong
[Relay][Frontend][TF] fix _parse_param bug (apache#4711)
a91303b
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@fwd4 @zhiics
[Relay][Frontend][TF] fix _parse_param bug (apache#4711)
76d93db
@yzhliu yzhliu mentioned this pull request Jun 21, 2020
Merged
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchung100m cchung100m cchung100m approved these changes

@kevinthesun kevinthesun kevinthesun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwd4 @kevinthesun @cchung100m