Fix padding in pooling op #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@optima2005 @masahi @anijain2305 @alexgl-github @kevinthesun Can you have a look? |
|
please add a test case |
vinx13
added
status: need review
status: need test case
|
How to test correctness of |
|
It's in |
|
you can just a test case where pooling has different pad size in each dimension. |
apivovarov
force-pushed
the
fix_pooling3d
branch
4 times, most recently
from
37308c4
to
534b60e
Compare
apivovarov
force-pushed
the
fix_pooling3d
branch
from
534b60e
to
a653c3c
Compare
|
The test case was added. @vinx13, @anijain2305 can you have a look again? |
vinx13
approved these changes
Jan 22, 2020
vinx13
added
status: accepted
and removed
status: need review
status: need test case
|
Thanks @apivovarov @masahi this is merged |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a bug in pooling op. The code calculates D, H and W padding but uses only D padding. H and W paddings are ignored.
More on the issue: https://discuss.tvm.ai/t/runtime-failed-for-5d-input/5429
This CR fixes it.