Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conv3d_ndhwc schedule #4775

Merged
merged 1 commit into from
Feb 1, 2020
Merged

conv3d_ndhwc schedule #4775

merged 1 commit into from
Feb 1, 2020

Conversation

alexgl-github
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@alexgl-github alexgl-github changed the title conv3d_nchw schedule conv3d_ndhwc schedule Jan 24, 2020
@alexgl-github alexgl-github marked this pull request as ready for review January 28, 2020 02:26
@alexgl-github alexgl-github force-pushed the sch_conv3d branch 7 times, most recently from 7e5b925 to 3546e95 Compare January 28, 2020 22:47
@alexgl-github
Copy link
Contributor Author

@apivovarov
@anijain2305
Could you please review again?

anijain2305
anijain2305 reviewed Jan 29, 2020
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgl-github Thanks for the contribution.

Almost every PR needs to have a test case in Apache TVM project. In this case, it can be a test case that uses this schedule and compares accuracy with some golden reference.

topi/python/topi/x86/conv3d.py Outdated Show resolved Hide resolved
topi/python/topi/x86/conv3d.py Show resolved Hide resolved
topi/python/topi/x86/conv3d.py Outdated Show resolved Hide resolved
@anijain2305
Copy link
Contributor

@vinx13 @kevinthesun for further reviews.

@alexgl-github alexgl-github requested review from vinx13 and kevinthesun and removed request for kevinthesun January 29, 2020 00:55
@alexgl-github
Copy link
Contributor Author

@alexgl-github Thanks for the contribution.

Almost every PR needs to have a test case in Apache TVM project. In this case, it can be a test case that uses this schedule and compares accuracy with some golden reference.

There's already topi conv3d_ndhwc test using this schedule:
https://github.com/apache/incubator-tvm/blob/1b8522e475e9a889b80f069a83928cafa3502a74/topi/tests/python/test_topi_conv3d_ndhwc.py#L60

@alexgl-github alexgl-github force-pushed the sch_conv3d branch 2 times, most recently from 241da70 to 019386c Compare January 30, 2020 17:15
icemelon
icemelon reviewed Jan 31, 2020
View reviewed changes
topi/python/topi/x86/conv3d.py Outdated Show resolved Hide resolved
topi/python/topi/x86/conv3d.py Outdated Show resolved Hide resolved
icemelon
icemelon approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@icemelon icemelon merged commit cf173fd into apache:master Feb 1, 2020
@icemelon
Copy link
Member

icemelon commented Feb 1, 2020

Thanks @alexgl-github . This is now merged.

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@alexgl-github @alexwong
Add schedule for conv3d NDHWC layout (apache#4775)
2255940
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@alexgl-github @alexwong
Add schedule for conv3d NDHWC layout (apache#4775)
af1cb07
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@alexgl-github @zhiics
Add schedule for conv3d NDHWC layout (apache#4775)
6a3423e
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
@alexgl-github alexgl-github deleted the sch_conv3d branch November 3, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apivovarov apivovarov apivovarov left review comments

@anijain2305 anijain2305 anijain2305 left review comments

@icemelon icemelon icemelon approved these changes

@vinx13 vinx13 Awaiting requested review from vinx13

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexgl-github @anijain2305 @icemelon @apivovarov @vinx13