[Relay][Topi] Use SimplifyInference for L2 Normalization. #4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anijain2305
changed the title
yzhliu
approved these changes
Jan 31, 2020
|
Thanks @anijain2305 |
Merged
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason - Observed that l2_normalize (which is seemingly a sequence of element-wise op with one reduce op) was taking close to 15% of time in a ssd_vgg network.
This PR converts L2 normalize to a series of Relay expr, for which we have well-defined Relay passes and topi schedules. Therefore, the PR also removes topi compute/schedules.
@yidawang @yzhliu @tqchen @kazum @PariksheetPinjari909
No need of extra tests. The change is verified through existing tests.