Fix PRelu layout in Relay #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe worth adding a test to cover this use case? |
I will add it later. |
|
ping @FrozenGene |
|
I am a little busy this period. pls hold on of this pr, I will add test case as soon as possible. Sorry for this. |
|
@kevinthesun Have added the test case. |
|
ping @kevinthesun |
|
Thank you @FrozenGene for fixing this. This is now merged. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* Fix PRelu layout in Relay * Fix cpplint * Add PRelu test case
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* Fix PRelu layout in Relay * Fix cpplint * Add PRelu test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion: https://discuss.tvm.ai/t/gluon-model-with-prelu-crash-in-relay-build/2071/6
@kevinthesun @eqy