[Relay][Runtime] Add support for virtual machine Objects #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
changed the title
weberlo
reviewed
Apr 30, 2019
tqchen
requested changes
May 1, 2019
include/tvm/runtime/object.h
Outdated
| */ | ||
| class Object { | ||
| public: | ||
| ObjectPtr<ObjectCell> ptr; |
There was a problem hiding this comment.
because we do not want the user to touch ptr, consider rename to ptr_,
|
Some minor nits. After some thoughts, I personally do not like the fact that Node and Object system are separate. Eventually, we want to merge them into a single node system, but still have a clear separation of compiler and runtime node objects. For now, we could even reuse the NodeBase class for object(which allows the effective use of make_node). This may need to happen in a few months and I don't want to block the PR, but it might be helpful to keep that in mind when polishing this PR, e.g., the naming(XXXCell-> XXXNode?). Possible way of unification, for reference:
|
tqchen
approved these changes
May 1, 2019
wweic
approved these changes
May 1, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the functionality for passing
runtime::Objects around from the VM, VM memory manager and VM compiler.See #2810 and #2889.