Extend TensorComputeOp to allow scalar inputs (#2606). #3300
+97
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavies-huawei
force-pushed
the
scalar_inputs
branch
from
43f0a24 to
def8125
Compare
|
@ZihengJiang can you please review? |
|
@kevinthesun can you add me to the slack channel? I requested on TVM discuss https://discuss.tvm.ai/t/request-for-invite-to-the-slack-channel/2888 3 days ago, but I haven't gotten a response yet. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second pull request for this change. In response to comments from @ZihengJiang, the scalar inputs can now be passed to the TensorIntrin without using a named parameter.
Before:
Now: