Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tensorflow operators log1p, cos, sin #3614

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

alexgl-github
Copy link
Contributor

The patch adds support for Tensorflow operators log1p and cos
Tensorflow log1p is described at https://www.tensorflow.org/api_docs/python/tf/math/log1p
Tensorflow cos is described at https://www.tensorflow.org/api_docs/python/tf/math/cos

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@yongwww
Copy link
Member

yongwww commented Jul 24, 2019

@srkreddy1238 @yzhliu @icemelon9 @zhiics @wweic good to get review from you guys

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems log1p can be handled in tf frontend converter python/tvm/relay/frontend/tensorflow.py

@kevinthesun
Copy link
Contributor

kevinthesun commented Jul 25, 2019

Agree that we should try to use existing relay op to compose new op.

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add tests in topi and relay for cos. tests/python/relay/test_op_levelXX.py topi/tests/python/test_topi_basic.py, topi/tests/python/test_topi_math.py,

The patch adds support for Tensorflow operators log1p and cos
Tensorflow log1p is described at https://www.tensorflow.org/api_docs/python/tf/math/log1p
Tensorflow cos is described at https://www.tensorflow.org/api_docs/python/tf/math/cos
Tensorflow sin is described at https://www.tensorflow.org/api_docs/python/tf/math/sin
@alexgl-github alexgl-github changed the title Add support for Tensorflow operators log1p and cos Add support for Tensorflow operators log1p, cos, sin Jul 31, 2019
@tqchen tqchen merged commit d72cdfa into apache:master Aug 1, 2019
@tqchen
Copy link
Member

tqchen commented Aug 1, 2019

Thanks @alexgl-github , @yongwww @kevinthesun this PR is now merged

@alexgl-github alexgl-github deleted the tf-log1p-cos branch August 1, 2019 21:23
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
The patch adds support for Tensorflow operators log1p and cos
Tensorflow log1p is described at https://www.tensorflow.org/api_docs/python/tf/math/log1p
Tensorflow cos is described at https://www.tensorflow.org/api_docs/python/tf/math/cos
Tensorflow sin is described at https://www.tensorflow.org/api_docs/python/tf/math/sin
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
The patch adds support for Tensorflow operators log1p and cos
Tensorflow log1p is described at https://www.tensorflow.org/api_docs/python/tf/math/log1p
Tensorflow cos is described at https://www.tensorflow.org/api_docs/python/tf/math/cos
Tensorflow sin is described at https://www.tensorflow.org/api_docs/python/tf/math/sin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants