-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][TopHub] Add switch to disable TopHub download #4015
Conversation
This seems to be a behavior that can be configured by env variable, by specifying the tophub location rather than putting it into a build. We could avoid download when the location is specified to be none |
I’m fine with that solution, but it doesn’t seem backward compatible for people who depend on tophub today. Do you know if a lot of people rely on it? I suppose this could work if we used the default location when the environment variable isn’t set, and if we set it to NONE explicitly then we don’t download. That seems a little strange though. |
Let us keep the backward compact by setting the default loc if not set for now. |
Updated to read from environment variable |
@merrymercy @yzhliu would you be able to take a look? |
@soiferj Thanks. It is merged |
* master: (21 commits) [Fix][VM] Fix VM invoke with set_params (apache#4079) [QNN] Refactor fixed point multiplication in requantize (apache#4073) Fix match case in Python-side expr functor (apache#4037) Hide symbols from dependent libraries if HIDE_PRIVATE_SYMBOLS is ON. (apache#4041) Add gradient for log-softmax (apache#4069) [DOC] Fix typos in tutorials (apache#4066) dicrease the complexity of CalcDep from exponential to linear (apache#4053) [Relay][AlterOp] Minor refactor. (apache#4064) [Relay][AlterOp] Improving support for broadcast layout alteration. (apache#4040) Add parses support for zeros_like tflite operator (apache#4042) [Bugfix][TF] reset graph after getting tag of savedmodel (apache#4055) [Relay][VM] Add more passes to VMCompiler (apache#4058) [Relay][VM] Add autotvm context when compile (apache#4062) [Bugfix] Fix target host for vm compiler (apache#4057) [Relay][Training] Add gradient for Crossentropy (apache#3925) [llvm] switch to use Align for llvm trunk (apache#4051) [Relay][TopHub] Add switch to disable TopHub download (apache#4015) [Relay][Op] Add instance norm op (apache#4004) [QNN][Relay] Calling Dialect passes from inside Relay Build API. (apache#3971) [RELAY/PASS] Fix the extent for the post_stmt in the loop partition (apache#3734) ...
Add a switch to disable downloading from TopHub. On machines which don't have internet access, failing to download from TopHub slows down
relay.build
significantly.@merrymercy would you be able to take a look?