Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] add benchmark log format doc #4366

Merged
merged 4 commits into from
Dec 2, 2019
Merged

Conversation

anwang2009
Copy link
Contributor

@anwang2009 anwang2009 commented Nov 18, 2019

Adds benchmark log format as discussed in

https://discuss.tvm.ai/t/rfc-benchmark-performance-log-format/4610

#4304

@tqchen
@u99127 since you expressed interest in getting your two cents in -- above github issue #4304 is more readable

@tqchen tqchen changed the title add benchmark log format doc [DOCS] add benchmark log format doc Nov 18, 2019
docs/dev/benchmark.rst Outdated Show resolved Hide resolved
docs/dev/benchmark.rst Outdated Show resolved Hide resolved
docs/dev/benchmark.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anwang2009 for the documentation on the benchmark log format.

docs/dev/benchmark.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest consistency in terminology. 'engine' doesn't mean much to me as a TVM developer and I would suggest favouring intuitiveness when understanding it ?

docs/dev/benchmark.rst Outdated Show resolved Hide resolved
docs/dev/benchmark.rst Outdated Show resolved Hide resolved
docs/dev/benchmark.rst Outdated Show resolved Hide resolved
docs/dev/benchmark.rst Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented Nov 23, 2019

@u99127 would be great if you can bring the proposed changes to the RFC discussion. Given that this is a proposal for standard among the community, it is important that all the field changes leaves a trace of discussion, Thanks!

@tqchen tqchen merged commit f931fe1 into apache:master Dec 2, 2019
@tqchen
Copy link
Member

tqchen commented Dec 2, 2019

Thanks @u99127 @anwang2009 !

tmoreau89 pushed a commit to tmoreau89/tvm that referenced this pull request Dec 3, 2019
* add benchmark log format doc

* code review changes

* remove runtime_config, add md5 field

* schema edits
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Dec 13, 2019
* add benchmark log format doc

* code review changes

* remove runtime_config, add md5 field

* schema edits
zxy844288792 pushed a commit to neo-ai/tvm that referenced this pull request Dec 13, 2019
* add benchmark log format doc

* code review changes

* remove runtime_config, add md5 field

* schema edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants