Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldb pretty printers for relay #4453

Merged
merged 2 commits into from
Dec 4, 2019
Merged

lldb pretty printers for relay #4453

merged 2 commits into from
Dec 4, 2019

Conversation

Leo-arm
Copy link
Contributor

@Leo-arm Leo-arm commented Dec 2, 2019

A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.
Put the dot.lldbinit file in your home directory as .lldbinit.
Update the file to point to the pretty printer script tvm.py
Restart lldb.

@@ -0,0 +1,201 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a separate package and cannot be imported separately, let us put it under apps/lldb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Files have been moved.

Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nits

@@ -0,0 +1,3 @@
# Put this file in your home directory as .lldbinit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this file also allows comment, please add an ASF header as in the py file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,3 @@
# Put this file in your home directory as .lldbinit
# Update the line below to point to the pretty printer script
command script import ~/bin/lldb/tvm.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~/bin/lldb/tvm.py /path/to/tvm/apps/lldb/tvm.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tqchen tqchen added the status: need update need update based on feedbacks label Dec 3, 2019
A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.
A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.
- Put the dot.lldbinit file in your home directory as .lldbinit.
- Update the file to point to the pretty printer script tvm.py
- Restart lldb
@tqchen tqchen merged commit f214364 into apache:master Dec 4, 2019
@tqchen
Copy link
Member

tqchen commented Dec 4, 2019

Thanks @Leo-arm !

@tqchen tqchen added status: accepted and removed status: need review status: need update need update based on feedbacks labels Dec 4, 2019
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Dec 13, 2019
* lldb pretty printers for relay

A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.

* lldb pretty printers for relay

A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.
- Put the dot.lldbinit file in your home directory as .lldbinit.
- Update the file to point to the pretty printer script tvm.py
- Restart lldb
zxy844288792 pushed a commit to neo-ai/tvm that referenced this pull request Dec 13, 2019
* lldb pretty printers for relay

A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.

* lldb pretty printers for relay

A set of lldb debugger pretty printers that use the relay
PrettyPrinter functionality to display data structures in
the lldb debugger.
- Put the dot.lldbinit file in your home directory as .lldbinit.
- Update the file to point to the pretty printer script tvm.py
- Restart lldb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants