Workaround to make conv2d_transpose compilation for CUDA work #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
reviewed
Dec 6, 2019
| @@ -186,7 +186,9 @@ def _callback(op): | |||
|
|
|||
| if cfg.is_fallback: | |||
| N, F, Y, X = get_const_tuple(conv.shape) | |||
| _fallback_schedule(N, F, Y, X) | |||
| # Workaround to make CUDA compilation work. Issue #4470 | |||
There was a problem hiding this comment.
Can we still use the fallback for the other cases by checking the input params here?
There was a problem hiding this comment.
I checked more kernel and strides combinations and found that the error happens when kernel is equal to strides, e.g.
# kernel and strides when compilation for CUDA fails
2x2 and (2,2)
3x3 and (3,3)
4x4 and (4,4)
5x5 and (5,5)
2x3 and (2,3)
3x2 and (3,2)
1x2 and (1x2)
etc
I also found that the compilation fails if output channel is 1
There was a problem hiding this comment.
added kernel / strides check and skip _fallback_schedule when output channel is 1.
In other case It will run _fallback_schedule for kernel 1x1 or when kernel != strides
apivovarov
force-pushed
the
fix_conv2d_transpose
branch
from
f339b26
to
89056d4
Compare
apivovarov
force-pushed
the
fix_conv2d_transpose
branch
from
89056d4
to
10f4b18
Compare
vinx13
approved these changes
Dec 8, 2019
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Dec 13, 2019
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 13, 2019
alexgl-github
added a commit
to alexgl-github/tvm
that referenced
this pull request
Jan 21, 2020
- combine pad and dilate; - fix for the issue https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164 - fix for the issue apache#4472
alexgl-github
added a commit
to alexgl-github/tvm
that referenced
this pull request
Jan 21, 2020
- combine pad and dilate; - fix for the issue https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164 - fix for the issue apache#4472
vinx13
pushed a commit
that referenced
this pull request
Jan 22, 2020
- combine pad and dilate; - fix for the issue https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164 - fix for the issue #4472
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
- combine pad and dilate; - fix for the issue https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164 - fix for the issue apache#4472
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
- combine pad and dilate; - fix for the issue https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164 - fix for the issue apache#4472
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
- combine pad and dilate; - fix for the issue https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164 - fix for the issue apache#4472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for issue #4470
Discussions:
https://discuss.tvm.ai/t/conv2d-transpose-kernel-2x2-strides-2-2-fails-for-cuda-cannot-prove/5020
https://discuss.tvm.ai/t/compile-error-for-cuda-target/4164