[CONTRIB][CC] Enhance cc.cross_compiler #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhance cc.cross_compiler to take str argument. - Remove cc.build_create_shared_func as it is dupilicated with cross_compiler - Add examples to cc.cross_compiler
jroesch
approved these changes
Feb 5, 2020
FrozenGene
requested changes
Feb 5, 2020
python/tvm/contrib/cc.py
Outdated
| cc.cross_compiler("arm-linux-gnueabihf-gcc")) | ||
| # specialize ndk compilation options. | ||
| specialized_ndk = cc.cross_compiler( | ||
| ndk.create_shared, ["--sysroot=/path/to/sysroot"]) |
There was a problem hiding this comment.
options should be better changed into ["--sysroot=/path/to/sysroot", "-shared", "-fPIC", "-lm"], because when users pass options into ndk, we won't append the latter three options so that we won't compile into shared libraries.
|
@FrozenGene please take another look |
FrozenGene
approved these changes
Feb 6, 2020
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Feb 10, 2020
* [CONTRIB][CC] Enhance cc.cross_compiler - Enhance cc.cross_compiler to take str argument. - Remove cc.build_create_shared_func as it is dupilicated with cross_compiler - Add examples to cc.cross_compiler * address review comments
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* [CONTRIB][CC] Enhance cc.cross_compiler - Enhance cc.cross_compiler to take str argument. - Remove cc.build_create_shared_func as it is dupilicated with cross_compiler - Add examples to cc.cross_compiler * address review comments
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* [CONTRIB][CC] Enhance cc.cross_compiler - Enhance cc.cross_compiler to take str argument. - Remove cc.build_create_shared_func as it is dupilicated with cross_compiler - Add examples to cc.cross_compiler * address review comments
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* [CONTRIB][CC] Enhance cc.cross_compiler - Enhance cc.cross_compiler to take str argument. - Remove cc.build_create_shared_func as it is dupilicated with cross_compiler - Add examples to cc.cross_compiler * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @FrozenGene @merrymercy @apivovarov