improve antlr import error message #4888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the error message I get from the parser import failure is confusing.
If I try to use VM functionality, I get an error
Couldn't find ANTLR parser. Try building with USE_ANTLR=ON.
But even if I rebuild TVM with USE_ANTLR=ON, I still get the same error because the generated parser try to import the antlr4 python package that I haven't installed, but the error still saysTry building with USE_ANTLR=ON
.This is confusing, I think
should come before
because the latter depends on the antlr4 python package.
please review @wweic @zhiics @icemelon9