[TFLITE]Activation functions support #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the operations already exist in another PR #4805 |
|
@inadob thanks for letting me know., i didnt noticed, i will update my PR. |
wyc-ruiker
reviewed
Mar 3, 2020
inadob
suggested changes
Mar 3, 2020
| @@ -1688,6 +1715,9 @@ def test_forward_mediapipe_hand_landmark(): | |||
| test_forward_prelu() | |||
| test_forward_fully_connected() | |||
| test_forward_l2_normalization() | |||
| # The below activations come with TFLite >= 1.14.0 fbs schema | |||
| if package_version.parse(tf.VERSION) >= package_version.parse('1.14.0'): | |||
There was a problem hiding this comment.
move the version check inside test_forward_local_response_normalization()
| alpha = alpha * size | ||
| axis = 3 # NHWC format | ||
| out = _op.nn.lrn(in_expr, size=size, axis=axis, bias=bias, alpha=alpha, beta=beta) | ||
| return out |
There was a problem hiding this comment.
I think it would be better to add an empty line before the return. The same applies to the rest of the functions.
| @@ -685,6 +723,22 @@ def convert_neg(self, op): | |||
| 'TFlite quantized NEG operator is not supported yet.') | |||
| return self._convert_unary_elemwise(_op.negative, op) | |||
|
|
|||
| def convert_elu(self, op): | |||
| """Convert TFLite ELU""" | |||
There was a problem hiding this comment.
Please, add the necessary imports.
siju-samuel
force-pushed
the
tflite_activations
branch
from
dc4b9dd
to
c77d4ce
Compare
inadob
approved these changes
Mar 4, 2020
siju-samuel
force-pushed
the
tflite_activations
branch
from
c77d4ce
to
0508c26
Compare
|
Rebased to latest. |
FrozenGene
reviewed
Mar 9, 2020
Comment on lines
+65
to
+77
| 'ADD': self.convert_add, | ||
| 'AVERAGE_POOL_2D': self.convert_average_pool2d, | ||
| 'BATCH_TO_SPACE_ND': self.convert_batch_to_space_nd, | ||
| 'CAST': self.convert_cast, | ||
| 'CEIL': self.convert_ceil, | ||
| 'CONCATENATION': self.convert_concatenation, | ||
| 'CONV_2D': self.convert_conv2d, | ||
| 'COS': self.convert_cos, | ||
| 'DEPTHWISE_CONV_2D': self.convert_depthwise_conv2d, | ||
| 'DETECTION_POSTPROCESS': self.convert_detection_postprocess, | ||
| 'DIV': self.convert_div, | ||
| 'ELU': self.convert_elu, | ||
| 'EQUAL': self.convert_equal, |
There was a problem hiding this comment.
Do you change it as alphabetical order?
There was a problem hiding this comment.
@FrozenGene Yes. its better to be in alphabetical order like TF. And it reduces the conflicts while merging PR.
FrozenGene
approved these changes
Mar 11, 2020
|
Thanks, it is merged |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [TFLITE]elu, leaky_relu, lrn, log_softmax activation functions * removed ops present in pr 4805 * review_comments updated
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [TFLITE]elu, leaky_relu, lrn, log_softmax activation functions * removed ops present in pr 4805 * review_comments updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELU, LEAKY_RELY, LRN, LOG_SOFTMAX activation functions supported for tflite frontend.
Along with this PR, i sorted the op list of tflite.
@FrozenGene @anijain2305 @wyc-ruiker Please help to review. TIA
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.