Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autotvm] Fix autotvm customized template #5034

Merged
merged 3 commits into from
Mar 12, 2020
Merged

[Autotvm] Fix autotvm customized template #5034

merged 3 commits into from
Mar 12, 2020

Conversation

icemelon
Copy link
Member

Fix the issue that autotvm customized template cannot get the config from dispatcher.

see details: https://discuss.tvm.ai/t/autotvm-error-in-the-conv2d-auto-tuning-tutorial-cannot-find-config-for-target-cuda-workload-none-etc/5919

@icemelon
Copy link
Member Author

cc @comaniac @merrymercy @ZihengJiang

comaniac
comaniac approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious. Why rename register_task_compute to _register_task_compute? Is that because you don't want those three functions to be exposed by default?

@icemelon
Copy link
Member Author

@comaniac Yes, I think _regsiter_task_compute, _regsiter_task_schedule, _regsiter_customized_template should not be user facing APIs. We should use register_topi_compute, register_topi_schedule, template instead.

@comaniac
Copy link
Contributor

@comaniac Yes, I think _regsiter_task_compute, _regsiter_task_schedule, _regsiter_customized_template should not be user facing APIs. We should use register_topi_compute, register_topi_schedule, template instead.

I see. Make sense to me.

kevinthesun
kevinthesun approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit 70e11d3 into apache:master Mar 12, 2020
@kevinthesun
Copy link
Contributor

Thanks @icemelon9 @comaniac

@icemelon icemelon deleted the autotvm-getconfig branch March 12, 2020 18:30
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
@icemelon
[Autotvm] Fix autotvm customized template (apache#5034)
40f7116 
* init

* fix template

* tweak naming
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@icemelon
[Autotvm] Fix autotvm customized template (apache#5034)
9aa5fc0 
* init

* fix template

* tweak naming
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@icemelon @zhiics
[Autotvm] Fix autotvm customized template (apache#5034)
3191c7f 
* init

* fix template

* tweak naming
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@kevinthesun kevinthesun kevinthesun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icemelon @comaniac @kevinthesun