Duplicate likely nodes added when loop axis split unevenly #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle reminder : @tqchen, @zhiics, @MarisaKirisame |
zhiics
reviewed
Mar 20, 2020
ANSHUMAN87
force-pushed
the
duplicate-likely-bug-fix
branch
from
1f5d949
to
0c597ed
Compare
|
@zhiics : Thanks for your comment! It is handled now. |
MarisaKirisame
approved these changes
Mar 20, 2020
|
@yzhliu can you take a look? Thanks. |
ANSHUMAN87
force-pushed
the
duplicate-likely-bug-fix
branch
from
0c597ed
to
20437f9
Compare
|
@MarisaKirisame : Thanks for your comment! It is handled now. |
|
@zhiics , @MarisaKirisame : Thanks for your review! |
|
@yzhliu: Gentle reminder! |
yzhliu
approved these changes
Mar 25, 2020
zhiics
approved these changes
Mar 25, 2020
|
Thanks @ANSHUMAN87 @MarisaKirisame @yzhliu |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [TE][Schedule] Duplicate likely nodes removed * [1] Test case added * [2] Lint error fixed * [3] Review comments handled * [4] Review comments handled
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [TE][Schedule] Duplicate likely nodes removed * [1] Test case added * [2] Lint error fixed * [3] Review comments handled * [4] Review comments handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1:> This PR handles duplicate likely nodes added when loop axis is split into non-divisible factors.
2:> The scenario is covered in the test case.