Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Realy] Replace UseDefaultCompiler with GetAttr #5088

Merged
merged 1 commit into from
Mar 18, 2020
Merged

[Realy] Replace UseDefaultCompiler with GetAttr #5088

merged 1 commit into from
Mar 18, 2020

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Mar 17, 2020

As mentioned in #5045, we should remove udeDefaultCompiler from Function and use GetAttr instead.

cc @tqchen @comaniac @mbaret

comaniac
comaniac approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the semantic of !kCompiler.defined() is using TVM builtin codegen seems a bit weird.

@tqchen tqchen merged commit 06bbc7c into apache:master Mar 18, 2020
@tqchen
Copy link
Member

tqchen commented Mar 18, 2020

Merge it in for now, see related discussion https://discuss.tvm.ai/t/target-and-attributes/6013/

@zhiics zhiics deleted the compiler_attr branch March 18, 2020 04:22
@zhiics zhiics restored the compiler_attr branch March 20, 2020 02:19
@zhiics zhiics deleted the compiler_attr branch March 20, 2020 02:22
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@zhiics
Replace UseDefaultCompiler with GetAttr (apache#5088)
0123e22
zhiics added a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@zhiics
Replace UseDefaultCompiler with GetAttr (apache#5088)
1386abb
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiics @tqchen @comaniac