[Runtime][MISRA-C][Bundle] Bundle deployment with static linking #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
reviewed
Mar 27, 2020
tmoreau89
reviewed
Mar 27, 2020
siju-samuel
reviewed
Mar 28, 2020
| demo: $(build_dir)/demo $(build_dir)/bundle.so $(build_dir)/bundle_c.so $(build_dir)/cat.bin | ||
| TVM_NUM_THREADS=1 $(build_dir)/demo $(build_dir)/bundle.so $(build_dir)/cat.bin | ||
| TVM_NUM_THREADS=1 $(build_dir)/demo $(build_dir)/bundle_c.so $(build_dir)/cat.bin | ||
| demo_dynamic: $(build_dir)/demo_dynamic $(build_dir)/bundle.so $(build_dir)/bundle_c.so $(build_dir)/cat.bin |
There was a problem hiding this comment.
apps/bundle_deploy/README.md needs to be updated?
There was a problem hiding this comment.
I updated the README file. Please let me know if you have any suggestions.
|
cc @liangfu |
liangfu
approved these changes
Mar 29, 2020
| demo: $(build_dir)/demo $(build_dir)/bundle.so $(build_dir)/bundle_c.so $(build_dir)/cat.bin | ||
| TVM_NUM_THREADS=1 $(build_dir)/demo $(build_dir)/bundle.so $(build_dir)/cat.bin | ||
| TVM_NUM_THREADS=1 $(build_dir)/demo $(build_dir)/bundle_c.so $(build_dir)/cat.bin | ||
| demo_dynamic: $(build_dir)/demo_dynamic $(build_dir)/bundle.so $(build_dir)/bundle_c.so $(build_dir)/cat.bin |
There was a problem hiding this comment.
update README.md to reflect this change.
tmoreau89
approved these changes
Mar 29, 2020
There was a problem hiding this comment.
thanks @mehrdadhe the changes LGTM! Can you re-trigger the CI, there has been some issues with CI build due to some VTA re-factoring.
|
@tmoreau89 I have pushed a commit. |
|
Thank you @mehrdadhe @siju-samuel @liangfu! The PR has been merged! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
…che#5158) * test file for static link added * rename files * Fixed static linking issue * cleanup * changed to dynamic and static demo * MISRA-C static and dynamic test * cleanup * cleanup * Update README.md * cleanup headers * update readme
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
…che#5158) * test file for static link added * rename files * Fixed static linking issue * cleanup * changed to dynamic and static demo * MISRA-C static and dynamic test * cleanup * cleanup * Update README.md * cleanup headers * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation in MISRA-C bundle deployment depends on dynamic linker. This PR adds demo and test which does not rely on dynamic linking using dlopen function.