Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR][IR] Remove AttrsEqual and AttrsHash related code #5169

Merged
merged 1 commit into from
Mar 30, 2020
Merged

[REFACTOR][IR] Remove AttrsEqual and AttrsHash related code #5169

merged 1 commit into from
Mar 30, 2020

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Mar 29, 2020

Last bit of #5159

This PR

  • replaces AttrsEqual and AttrsHash with StructuralEqual and StructuralHash, respectively.
  • removes the handlers that used as utilities for these two removed classes.
  • fixes a small bug for structural equal when both lhs and rhs are null objects.

cc @tqchen @MarisaKirisame

@tqchen tqchen merged commit 6536b35 into apache:master Mar 30, 2020
@zhiics zhiics deleted the attrs branch March 30, 2020 04:05
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@zhiics
remove AttrsEqual and AttrsHash related code (apache#5169)
0422047
zhiics added a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@zhiics
remove AttrsEqual and AttrsHash related code (apache#5169)
ce12e0a
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@MarisaKirisame MarisaKirisame MarisaKirisame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiics @tqchen @MarisaKirisame