[RUNTIME] Auto conversion from str to runtime::String in PackedFUnc #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dFunc, move dtype related handling to data_type.h
zhiics
approved these changes
Apr 6, 2020
zhiics
reviewed
Apr 7, 2020
| @@ -554,6 +512,10 @@ class TVMArgValue : public TVMPODValue_ { | |||
| return std::string(value_.v_str); | |||
| } | |||
| } | |||
| operator tvm::runtime::String() const { | |||
| // directly use the std::string constructor for now. | |||
| return tvm::runtime::String(operator std::string()); | |||
There was a problem hiding this comment.
@tqchen It happened to me that Line511 above failed for the check because the type_code_ for String is an object. Should we remove this and pass String objectref directly? Or do we need to handle String through FFI?
There was a problem hiding this comment.
Ah, i see, good catch, we will need to add a patch, by checking if the result is kStr and run this, alternatively, use AsObjectRef
There was a problem hiding this comment.
so let's just return AsObjectRef<tvm::runtime::String>() for now?
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
…dFunc, move dtype related handling to data_type.h (apache#5251)
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
…dFunc, move dtype related handling to data_type.h (apache#5251)
dpankratz
pushed a commit
to dpankratz/incubator-tvm
that referenced
this pull request
Apr 24, 2020
…dFunc, move dtype related handling to data_type.h (apache#5251)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves dtype related handling to data_type.h