Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Fixes for wasm32 target #5489

Merged
merged 4 commits into from
May 2, 2020
Merged

[Rust] Fixes for wasm32 target #5489

merged 4 commits into from
May 2, 2020

Conversation

kazum
Copy link
Contributor

@kazum kazum commented Apr 30, 2020

This PR fixes warnings and errors when targeting wasm32.

  • Update the BackendPackedCFunc signature which was changed in [RUNTIME][DSO] Improve TVMBackendPackedCFunc to allow return val #4637.
  • Use derive_default() for bindgen to handle the generated padding field.
  • Add workaround for nom::length_data, which doesn't allow u64 on 32-bit architecture.
  • Terminate the thread safely instead of panic when crossbeam-channel is closed.
  • Remove unused import warnings.

@jroesch @nhynes @ehsanmok @tqchen Please help to review.

@ehsanmok
Copy link
Contributor

Thanks @kazum! LGTM.

@jroesch
Copy link
Member

jroesch commented Apr 30, 2020

Could you actually add some kind of test which checks that we compile correctly for WASM target?

@kazum kazum mentioned this pull request May 1, 2020
Merged
@tqchen tqchen merged commit c7a16d8 into apache:master May 2, 2020
Laurawly pushed a commit to Laurawly/tvm-1 that referenced this pull request May 9, 2020
@kazum @Laurawly
[Rust] Fixes for wasm32 target (apache#5489)
e95748a 
* [Rust] Fixes for wasm32 target

* [Rust] Add test for wasm32

* allow cargo config to be into repo

* Disable wasm tests in CI
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 9, 2020
@kazum
[Rust] Fixes for wasm32 target (apache#5489)
2775f7e 
* [Rust] Fixes for wasm32 target

* [Rust] Add test for wasm32

* allow cargo config to be into repo

* Disable wasm tests in CI
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 18, 2020
@kazum
[Rust] Fixes for wasm32 target (apache#5489)
fd4502f 
* [Rust] Fixes for wasm32 target

* [Rust] Add test for wasm32

* allow cargo config to be into repo

* Disable wasm tests in CI
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 18, 2020
@kazum @trevor-m
[Rust] Fixes for wasm32 target (apache#5489)
0b2cac5 
* [Rust] Fixes for wasm32 target

* [Rust] Add test for wasm32

* allow cargo config to be into repo

* Disable wasm tests in CI
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jroesch jroesch jroesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazum @ehsanmok @jroesch @tqchen