-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Target] Introduce Target Id Registry #5838
[Target] Introduce Target Id Registry #5838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have simple testcases around target id
@junrushao1994 please rebase against the master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junrushao1994 : Thanks for the PR! Great work 👍
Please find some high level comments. Hope it is helpful. Thanks!
Thank you @ANSHUMAN87 for the review! |
@tqchen could you take another look? Changes
|
Note about the second level validation:
In the above example, the schema of cuda looks like
And we need to be able to validate the information in llvm. For example, if we add an invalid attribute to the target host map(that is not registered by llvm) it will trigger an error. |
@tqchen As far as I could understand, we need validation twice, one for target, one for target_host. Therefore, the step-by-step procedure should be:
Is that correct? BTW, why the schema of cuda doesn't include "libs" and "tag"? |
Sorrt i omitted the libs and tags, they should be. Would be great if we can have a test example |
@tqchen Just added support for |
see some additional followups about making Target as part of the schema, to recognize perhaps |
Future work may include:
|
Per RFC TVM Target Specification.
We implemented a target id registry which supports the following syntax: