Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Install DNNL (OneDNN) to CI Environment #5936

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

comaniac
Copy link
Contributor

The current BYOC flow uses DNNL as an example backend to demonstrate and test its functionality, but all related tests are currently skipped in CI due to the lack of DNNL in the environment. In this PR, we add scripts to deploy pre-built DNNL to the docker image so that the unit tests in #5919 for example can be effective.

I've built a docker image locally and passed unit tests of #5919 with it.

cc @zhiics @tqchen

@tqchen
Copy link
Member

tqchen commented Jun 26, 2020

Please confirm if the dnnl works with AMD cpu, as we also have AMD cpus in the CI.

@comaniac
Copy link
Contributor Author

comaniac commented Jun 26, 2020

OK will verify it on EC2 M5a instance and get back here.

@comaniac
Copy link
Contributor Author

Verified that this docker image with DNNL works for AMD CPU (EC2 m5a.4xlarge instance).

@tqchen tqchen merged commit 5786e82 into apache:master Jun 26, 2020
@tqchen
Copy link
Member

tqchen commented Jun 26, 2020

OK, this is merged. the binary need to be manually updated, will report back when it is ready,

@comaniac comaniac deleted the enable_ci_dnnl branch June 26, 2020 23:05
@comaniac
Copy link
Contributor Author

HI @tqchen have you got a chance to update docker hub? Thanks.

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
@tqchen
Copy link
Member

tqchen commented Jul 1, 2020

Update, I tried to update. There was some problems wrt to the ci-cpu(not related to this PR) that needs to be fixed http://ci.tvm.ai:8080/job/temp-ci-docker-staging/job/ci-stage/39/execution/node/324/log/ before we can update the image

@comaniac
Copy link
Contributor Author

comaniac commented Jul 1, 2020

Got it. Thanks for the update!

zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants