-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MXNet frontend support for AMP cast op #5976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Hmmm just to confirm, do we really want to keep those "fake" operators in the NNVM IR? |
icemelon
reviewed
Jul 3, 2020
This reverts commit a410dd5.
icemelon
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
* amp_cast * fix test * more tests * test more ctxs * fix doc * fix typo * address CR comment * fix lint * revert doc change * Revert "revert doc change" This reverts commit a410dd5. * fix doc * Update relay_pass_infra.rst Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
* amp_cast * fix test * more tests * test more ctxs * fix doc * fix typo * address CR comment * fix lint * revert doc change * Revert "revert doc change" This reverts commit a410dd5. * fix doc * Update relay_pass_infra.rst Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
Support
amp_cast
andamp_multicast
used by mxnet mixed precision. @icemelon9