Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MXNet frontend support for AMP cast op #5976

Merged
merged 14 commits into from
Jul 8, 2020
Merged

Conversation

eric-haibin-lin
Copy link
Member

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Support amp_cast and amp_multicast used by mxnet mixed precision. @icemelon9

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@junrushao
Copy link
Member

Hmmm just to confirm, do we really want to keep those "fake" operators in the NNVM IR?

python/tvm/relay/frontend/mxnet.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/mxnet.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/mxnet.py Outdated Show resolved Hide resolved
tests/python/frontend/mxnet/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/mxnet/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/mxnet/test_forward.py Outdated Show resolved Hide resolved
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemelon icemelon merged commit d9f009a into apache:master Jul 8, 2020
@icemelon
Copy link
Member

icemelon commented Jul 8, 2020

@eric-haibin-lin eric-haibin-lin deleted the cast branch July 8, 2020 18:56
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 14, 2020
* amp_cast

* fix test

* more tests

* test more ctxs

* fix doc

* fix typo

* address CR comment

* fix lint

* revert doc change

* Revert "revert doc change"

This reverts commit a410dd5.

* fix doc

* Update relay_pass_infra.rst

Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jul 14, 2020
* amp_cast

* fix test

* more tests

* test more ctxs

* fix doc

* fix typo

* address CR comment

* fix lint

* revert doc change

* Revert "revert doc change"

This reverts commit a410dd5.

* fix doc

* Update relay_pass_infra.rst

Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants