[IR] Fix a primitive check error #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Jul 6, 2020
include/tvm/ir/op.h
Outdated
| @@ -146,6 +146,7 @@ class OpNode : public RelayExprNode { | |||
| // Internal function to compute if it is primitive op | |||
| bool IsPrimitiveOp_() const { | |||
| const auto& fn_ty = this->op_type; | |||
| if (fn_ty.get() == 0) return false; | |||
There was a problem hiding this comment.
I am not too sure about the change. We should not use 0 in the case of nullptr.
Ideally all Op should have a Type. So instead, we might want to do CHECK(fn_ty != nullptr) here and make sure we register a type for every Op
There was a problem hiding this comment.
Thanks for pointing out.
I think I was trying to hash an Op with Type undefined, which led me to return false here. Otherwise, I would crash into a segfault error.
This is updated accordingly as suggested.
zhiics
approved these changes
Jul 8, 2020
tqchen
requested changes
Jul 8, 2020
tqchen
approved these changes
Jul 14, 2020
|
Thanks @liangfu , @junrushao1994 @zhiics |
tqchen
added
status: accepted
and removed
status: need update
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
* fix primitive check error * assuming every Op has Type defined * CHECK_NE -> CHECK Co-authored-by: Liangfu Chen <liangfc@amazon.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
* fix primitive check error * assuming every Op has Type defined * CHECK_NE -> CHECK Co-authored-by: Liangfu Chen <liangfc@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix an error that raised when hashing a Relay Op.
@zhiics @jroesch please review.