-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Caffe Frontend] add caffe environment #6023
Conversation
May you help me review this pr? @siju-samuel @Huyuwei @hlu1 |
Based on disscution above, there are two kinds of ways to support caffe frontend in TVM:
We are very welcome to participate in the discussion!https://discuss.tvm.ai/t/introduce-new-frontend-for-caffe/6918 @tqchen @siju-samuel @zhiics @Huyuwei @hlu1 @kazum @srkreddy1238 |
Gental ping @tqchen @siju-samuel |
I vote for second option. BVLC caffe models will have more users compared to forked versions. |
Yes, bvlc distribution has supported for precompiled caffe installation, and It's really convenient to use. |
Hi @FrozenGene @siju-samuel @tqchen : May you please review them? If there is no problem, I hope to merge as soon as possible in order to pass the CI test of caff front-end codes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final comments
docker/Dockerfile.ci_gpu
Outdated
@@ -83,6 +83,9 @@ RUN bash /install/ubuntu_install_dgl.sh | |||
COPY install/ubuntu_install_vulkan.sh /install/ubuntu_install_vulkan.sh | |||
RUN bash /install/ubuntu_install_vulkan.sh | |||
|
|||
COPY install/ubuntu_install_caffe.sh /install/ubuntu_install_caffe.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just install the caffe on the CPU and run ci tests through the CPU side? This would reduce our pressure in terms of depending on the GPU resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add the tests to here https://github.com/apache/incubator-tvm/blob/master/tests/scripts/task_python_frontend_cpu.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, if we just install the caffe on the CPU, it will reduce a lot of work.
|
||
apt install caffe-cpu -y | ||
|
||
pip install --upgrade scikit-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need pip3 instead of pip to introduce it to the python3 env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the codes, please review them, thanks.
…r precompiled caffe.
Thanks @fernchen This PR is now merged. Note that we still need to update the ci-cpu image, will rely to this thread once that is done. |
ci-cpu is now updated to the latest state |
* [CI][Caffe Frontend] add caffe environment * [CI][Caffe Frontend] change the caffe deps into BVLC distribution. * [CI][Caffe Fronted] simplify configuration while installing tzdata for precompiled caffe. * [CI][Caffe Frontend] add more information about tzdata. * [CI][CaffeFrontend]remove the ci for gpu env and change to pip3 env Co-authored-by: fernchen <zifeng.cf@alibaba-inc.com>
* [CI][Caffe Frontend] add caffe environment * [CI][Caffe Frontend] change the caffe deps into BVLC distribution. * [CI][Caffe Fronted] simplify configuration while installing tzdata for precompiled caffe. * [CI][Caffe Frontend] add more information about tzdata. * [CI][CaffeFrontend]remove the ci for gpu env and change to pip3 env Co-authored-by: fernchen <zifeng.cf@alibaba-inc.com>
* [CI][Caffe Frontend] add caffe environment * [CI][Caffe Frontend] change the caffe deps into BVLC distribution. * [CI][Caffe Fronted] simplify configuration while installing tzdata for precompiled caffe. * [CI][Caffe Frontend] add more information about tzdata. * [CI][CaffeFrontend]remove the ci for gpu env and change to pip3 env Co-authored-by: fernchen <zifeng.cf@alibaba-inc.com>
* [CI][Caffe Frontend] add caffe environment * [CI][Caffe Frontend] change the caffe deps into BVLC distribution. * [CI][Caffe Fronted] simplify configuration while installing tzdata for precompiled caffe. * [CI][Caffe Frontend] add more information about tzdata. * [CI][CaffeFrontend]remove the ci for gpu env and change to pip3 env Co-authored-by: fernchen <zifeng.cf@alibaba-inc.com>
* [CI][Caffe Frontend] add caffe environment * [CI][Caffe Frontend] change the caffe deps into BVLC distribution. * [CI][Caffe Fronted] simplify configuration while installing tzdata for precompiled caffe. * [CI][Caffe Frontend] add more information about tzdata. * [CI][CaffeFrontend]remove the ci for gpu env and change to pip3 env Co-authored-by: fernchen <zifeng.cf@alibaba-inc.com>
Since BVLC distribution support has successfully completed, it would be great if we could replace BVLC distribution with SSD distribution. Anyone working on that? |
Please go ahead. And you could tag @fernchen when you pull request. |
Recently,we try to introduce Caffe frontend to TVM, please to ref to #6000 , but original CI environment dose not support for Caffe. In order to pass CI test, we add Caffe environment including Caffe dependent packages and pycaffe for ssd-version, it comes from https://github.com/weiliu89/caffe
@zhiics @tqchen @FrozenGene
Could you please have a look on this PR? Thanks!