Fix conv2_gemm after target structure update #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After target structure changed in this RFC: https://discuss.tvm.ai/t/rfc-tvm-target-specification/6844/42 The conv2d optimizations was broken for the following reasons: - "target" is now called mtriple (this changes how we test if the architecture is AArch64) - when we invoke "clang.create_llvm" we still need to specify the "--target" option (set to aarch64-linux-gnu) This submission reverts those changes Change-Id: I04c597b91ca5800ddf4471255e2a358c60bc048e
tqchen
approved these changes
Jul 14, 2020
|
Thanks @giuseros ! CC @junrushao1994 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
After target structure changed in this RFC: https://discuss.tvm.ai/t/rfc-tvm-target-specification/6844/42 The conv2d optimizations was broken for the following reasons: - "target" is now called mtriple (this changes how we test if the architecture is AArch64) - when we invoke "clang.create_llvm" we still need to specify the "--target" option (set to aarch64-linux-gnu) This submission reverts those changes Change-Id: I04c597b91ca5800ddf4471255e2a358c60bc048e
|
I see. Thank you for the correction! |
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
After target structure changed in this RFC: https://discuss.tvm.ai/t/rfc-tvm-target-specification/6844/42 The conv2d optimizations was broken for the following reasons: - "target" is now called mtriple (this changes how we test if the architecture is AArch64) - when we invoke "clang.create_llvm" we still need to specify the "--target" option (set to aarch64-linux-gnu) This submission reverts those changes Change-Id: I04c597b91ca5800ddf4471255e2a358c60bc048e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After target structure changed in this RFC:
https://discuss.tvm.ai/t/rfc-tvm-target-specification/6844/42
The conv2d optimizations was broken for the following reasons:
architecture is AArch64)
"--target" option (set to aarch64-linux-gnu)
This submission reverts those changes
Change-Id: I04c597b91ca5800ddf4471255e2a358c60bc048e