Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSL/TE] Scalar support for te.extern #6079

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jul 16, 2020

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Fixed #6015 @ZihengJiang

@eric-haibin-lin eric-haibin-lin changed the title [WIP] [DSL/TE] Scalar support for te.extern [DSL/TE] Scalar support for te.extern Jul 18, 2020
@ZihengJiang
Copy link
Contributor

Hey Haibin , thanks for your help!

Could you try to enhance the test case with mixed Tensor and Scalar inputs like:

@tvm.register_func("tvm.test_tensor_scalar_scale")
def my_scale(tensor, scalar, out):
    out_np = tensor.asnumpy() * scalar
    tvm.nd.array(out_np).copyto(out)

@tqchen
Copy link
Member

tqchen commented Jul 21, 2020

@ZihengJiang please followup

@ZihengJiang ZihengJiang merged commit 7ac78d9 into apache:master Jul 21, 2020
@eric-haibin-lin eric-haibin-lin deleted the scalar branch July 21, 2020 01:39
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* fix make shape with scalar shapes

* add test

* add test

* remove scalar shape assertion

* fix the data type for overflow problems

* add extra tests

Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* fix make shape with scalar shapes

* add test

* add test

* remove scalar shape assertion

* fix the data type for overflow problems

* add extra tests

Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
* fix make shape with scalar shapes

* add test

* add test

* remove scalar shape assertion

* fix the data type for overflow problems

* add extra tests

Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
* fix make shape with scalar shapes

* add test

* add test

* remove scalar shape assertion

* fix the data type for overflow problems

* add extra tests

Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-138.ec2.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSL/TE] Scalar support for te.extern
3 participants