[WIP] Fix LocalBuilder on macOS with python 3.8. #6083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.8 changes the default way multiprocessing creates new processes on macOS from forking to spawing. Spawning requires all objects to be picklable. Nested functions and lambdas are not picklable, so this commit fixes the one instance of nested functions in the codebase that was causing issues.
tqchen
approved these changes
Jul 17, 2020
|
Thanks @tkonolige ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Python 3.8 changes the default way multiprocessing creates new processes on macOS from forking to spawing. Spawning requires all objects to be picklable. Nested functions and lambdas are not picklable, so this commit fixes the one instance of nested functions in the codebase that was causing issues.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Python 3.8 changes the default way multiprocessing creates new processes on macOS from forking to spawing. Spawning requires all objects to be picklable. Nested functions and lambdas are not picklable, so this commit fixes the one instance of nested functions in the codebase that was causing issues.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
Python 3.8 changes the default way multiprocessing creates new processes on macOS from forking to spawing. Spawning requires all objects to be picklable. Nested functions and lambdas are not picklable, so this commit fixes the one instance of nested functions in the codebase that was causing issues.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
Python 3.8 changes the default way multiprocessing creates new processes on macOS from forking to spawing. Spawning requires all objects to be picklable. Nested functions and lambdas are not picklable, so this commit fixes the one instance of nested functions in the codebase that was causing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 changes the default way multiprocessing creates new processes on macOS from forking to spawing. Spawning requires all objects to be picklable. Nested functions and lambdas are not picklable, so this commit fixes the one instance of nested functions in the codebase that was causing issues.
Although I've fixed the error from objects not being picklable, I'm getting an error in
tests/python/unittest/test_autotvm_measure.pywhere registered tasks aren't found. Looking inpython/tvm/autotvm/measure/local_executor.py, the globalTASK_TABLEis empty in some child processes. The error only occurs with python 3.8 and pytest. Runningtests/python/unittest/test_autotvm_measure.pydirectly (without pytest) gives no errors. I'd assume this issue is related to multiprocessing.