-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][VM] Add ReshapeTensor instruction in the VM to replace the reshape op #6089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please check the error. We have gpu context in the check_result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The GPU error seems to come from the check I added to fail early on GPU with dynamic models. I believe dynamic shapes wont work on cuda until we get heterogenous execution working for shape funcs, per our discussion in https://discuss.tvm.ai/t/issue-with-vm-execution-when-testing-gpu-immediately-after-cpu/7010/7 @zhiics, any update on that work? Or should we limit this test to CPU? |
@mbrookhart Yeah, I meant there is gpu context in the test. That's why the ci fails. We can probably just disable check_result for this test ATM. Heterogeneous execution needs this PR. |
Thanks @icemelon9 @mbrookhart |
@icemelon9 is_reshape_only is incorrect. If a function return a constant it will wrap a reshape on it. Please fix it in a principle way (e.g. not by checking that the whole function has at least one reshape, as this will not work on reshape of constant). |
…shape op (apache#6089) * [VM] Add reshape tensor instruction * update * lint * fix * fix
…shape op (apache#6089) * [VM] Add reshape tensor instruction * update * lint * fix * fix
…shape op (apache#6089) * [VM] Add reshape tensor instruction * update * lint * fix * fix
…shape op (apache#6089) * [VM] Add reshape tensor instruction * update * lint * fix * fix
@jroesch @zhiics @mbrookhart Could you help review?