Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoTVM][BugFix] Fix autotvm on the conv2d_nchw_winograd.mali operator #6130

Merged
merged 2 commits into from
Jul 24, 2020
Merged

[AutoTVM][BugFix] Fix autotvm on the conv2d_nchw_winograd.mali operator #6130

merged 2 commits into from
Jul 24, 2020

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Jul 23, 2020

This PR fixes two bugs related to autotvm on the conv2d_nchw_winograd.mali operator.

  • KeyError when computingkvshape
  • Duplicate args returned by autotvm.task.task.TaskTemplate.get_inputs

Due to the hack term here, both tensor output and tensor Y point to the same tensor M, which causes tensor M to be added in the queue twice. Using a hash set can remove duplicate nodes when performing level order traversal. @comaniac @kevinthesun @merrymercy

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit 659f12b into apache:master Jul 24, 2020
@kevinthesun
Copy link
Contributor

Thanks @ymwangg @comaniac

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…or (apache#6130)

* [AutoTVM] Fix conv2d_nchw_winograd.mali

* Fix pylint error

Co-authored-by: Yanming Wang <yanmwang@amazon.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…or (apache#6130)

* [AutoTVM] Fix conv2d_nchw_winograd.mali

* Fix pylint error

Co-authored-by: Yanming Wang <yanmwang@amazon.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…or (apache#6130)

* [AutoTVM] Fix conv2d_nchw_winograd.mali

* Fix pylint error

Co-authored-by: Yanming Wang <yanmwang@amazon.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
…or (apache#6130)

* [AutoTVM] Fix conv2d_nchw_winograd.mali

* Fix pylint error

Co-authored-by: Yanming Wang <yanmwang@amazon.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
…or (apache#6130)

* [AutoTVM] Fix conv2d_nchw_winograd.mali

* Fix pylint error

Co-authored-by: Yanming Wang <yanmwang@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants