-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction #6131
Conversation
@@ -770,7 +770,7 @@ class CompileEngineImpl : public CompileEngineNode { | |||
}; | |||
|
|||
/*! \brief The global compile engine */ | |||
const CompileEngine& CompileEngine::Global() { | |||
CompileEngine& CompileEngine::Global() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for dropping the const
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing the cache mutates the CompileEngine
, so in order to clear the cache after each build we need to modify the global state.
@tkonolige, looks like the CI got aborted, can you rebase and push to trigger a new run? |
CI is getting errors like this:
I have no clue how this PR is triggering those errors. |
@merrymercy, any idea why this change is triggering CI errors? |
@tkonolige Can you reproduce the error locally? If so, I guess |
@tkonolige I can reproduce the errors locally. Will look into it. |
@tqchen @merrymercy I can't figure this error out. Could one of you take a look at it? |
One of the failing tests is |
I pinged @zhiics since he is the owner afaik of this code, he said he would look at it tomorrow. |
Yeah, one quick thing I can do is to retire the example runtime since we have a real json runtime now. This example is not really use any more. I can send a PR later. cc @comaniac |
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
@merrymercy @tqchen We can merge this now. |
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Note: this makes
CompileEngine
a mutable global variable.@merrymercy @jwfromm