Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvm::support::hexdump() debug utility #6154

Merged
merged 10 commits into from
Aug 18, 2020
Merged

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Jul 28, 2020

Adding a debug utility which can be useful to inspect binary data in the C++ runtime.

As part of this change, build C++ tests against a statically-linked TVM runtime so that -fvisibility=hidden can still be used but doesn't apply to unit tests.

namespace tvm {
namespace support {

void hexdump(const std::string& s, std::ostream& os);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HexDump as per Google C convention

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

namespace tvm {
namespace support {

void hexdump(const std::string& s, std::ostream& os);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document via doxygen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tqchen tqchen marked this pull request as ready for review August 18, 2020 23:20
@tqchen tqchen merged commit 9b8eb81 into apache:master Aug 18, 2020
@tqchen
Copy link
Member

tqchen commented Aug 18, 2020

Thanks @areusch !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants