-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constant input attr added to fully connected operation in TFLite frontend #6228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on what the constant input attr does and how it relates to 'wrap'?
I'm still not really sure what's meant by the 'wrap' and can't find anything in the tensorflow/tflite docs named that. It appears to just control whether the input is a constant, in which case could we make it something more explicit like 'const_input'? |
An ability to handle constant input attr added to fully connected operation Unit tests amended.
9a4055e
to
427e592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@siju-samuel, @anijain2305 please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor typo suggestion.
Thanks @d-smirnov @mbaret This is merged! |
…tend (apache#6228) * Constant input attr added to fully connected operation An ability to handle constant input attr added to fully connected operation Unit tests amended. * renamed wrap_input to const_input * removed extra spaces
…tend (apache#6228) * Constant input attr added to fully connected operation An ability to handle constant input attr added to fully connected operation Unit tests amended. * renamed wrap_input to const_input * removed extra spaces
…tend (apache#6228) * Constant input attr added to fully connected operation An ability to handle constant input attr added to fully connected operation Unit tests amended. * renamed wrap_input to const_input * removed extra spaces
…tend (apache#6228) * Constant input attr added to fully connected operation An ability to handle constant input attr added to fully connected operation Unit tests amended. * renamed wrap_input to const_input * removed extra spaces
…tend (apache#6228) * Constant input attr added to fully connected operation An ability to handle constant input attr added to fully connected operation Unit tests amended. * renamed wrap_input to const_input * removed extra spaces
This PR adds an ability to handle constant input attr to "fully connected" operation. Unit tests amended.