Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant input attr added to fully connected operation in TFLite frontend #6228

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

d-smirnov
Copy link
Contributor

This PR adds an ability to handle constant input attr to "fully connected" operation. Unit tests amended.

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on what the constant input attr does and how it relates to 'wrap'?

tests/python/frontend/tflite/test_forward.py Show resolved Hide resolved
python/tvm/relay/frontend/tflite.py Show resolved Hide resolved
python/tvm/relay/frontend/tflite.py Show resolved Hide resolved
@mbaret
Copy link
Contributor

mbaret commented Aug 13, 2020

I'm still not really sure what's meant by the 'wrap' and can't find anything in the tensorflow/tflite docs named that. It appears to just control whether the input is a constant, in which case could we make it something more explicit like 'const_input'?

An ability to handle constant input attr added to fully connected operation
Unit tests amended.
Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-smirnov
Copy link
Contributor Author

@siju-samuel, @anijain2305 please take a look

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor typo suggestion.

tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
@anijain2305 anijain2305 merged commit e52c5ba into apache:master Aug 20, 2020
@anijain2305
Copy link
Contributor

Thanks @d-smirnov @mbaret This is merged!

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…tend (apache#6228)

* Constant input attr added to fully connected operation

An ability to handle constant input attr added to fully connected operation
Unit tests amended.

* renamed wrap_input to const_input

* removed extra spaces
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…tend (apache#6228)

* Constant input attr added to fully connected operation

An ability to handle constant input attr added to fully connected operation
Unit tests amended.

* renamed wrap_input to const_input

* removed extra spaces
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…tend (apache#6228)

* Constant input attr added to fully connected operation

An ability to handle constant input attr added to fully connected operation
Unit tests amended.

* renamed wrap_input to const_input

* removed extra spaces
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
…tend (apache#6228)

* Constant input attr added to fully connected operation

An ability to handle constant input attr added to fully connected operation
Unit tests amended.

* renamed wrap_input to const_input

* removed extra spaces
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
…tend (apache#6228)

* Constant input attr added to fully connected operation

An ability to handle constant input attr added to fully connected operation
Unit tests amended.

* renamed wrap_input to const_input

* removed extra spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants