Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC][ACL] Improved pooling support #6248

Merged
merged 5 commits into from
Aug 27, 2020
Merged

[BYOC][ACL] Improved pooling support #6248

merged 5 commits into from
Aug 27, 2020

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Aug 11, 2020 •
edited
Loading

This patch adds support for various pooling operators, namely: average pool 2d, global max pool 2d, global average pool 2d and l2 pooling (an equivalent combination of relay operators).

For fp32:

  • nn.avg_pool2d
  • nn.global_max_pool2d
  • nn.global_avg_pool2d
  • power(2) + nn.avg_pool2d + sqrt -> L2 pooling (only supports fp32)

For uint8:

  • cast + nn.avg_pool2d + cast
  • nn.global_max_pool2d
  • cast + nn.global_avg_pool2d + cast

Tests updated to reflect these changes.

cc @comaniac @zhiics @mbaret @Leo-arm

@lhutton1 lhutton1 force-pushed the acl-pooling-improvement branch 2 times, most recently from 7cde80a to 7940248 Compare August 25, 2020 08:45
@lhutton1
[BYOC][ACL] Improved pooling support
7a4433f 
Adds support in ACL for the following relay pooling operators and composite functions:
  * nn.avg_pool2d (fp32), cast + nn.avg_pool2d(uint8) + cast => AVG pool
  * nn.global_max_pool2d => Global MAX pool
  * nn.global_avg_pool2d, cast + nn.global_avg_pool2d(uint8) + cast => Global AVG pool
  * power(2) + nn.avg_pool2d + sqrt => L2 pooling (for fp32 only)

Tests updated to reflect these changes.

Change-Id: I1644b67b60ebb252344eb9695a521d2d958c724e
@lhutton1
Address comments
5f4209d 
Change-Id: Ibe8a61b4c42da246ce54701c89ea985b423c8f83
@lhutton1
Fix not checking output saturation
3c710ac 
Change-Id: Ia6f3d9db31cfb8c417d8556d29961210fea418b2
@lhutton1
Use defined set of trials
3d6f42f 
Change-Id: Ib180e3a0cbb84d6fa00c7e1994f58cb62662db15
@lhutton1
Rebase master
a19721c 
Change-Id: I5c932751cd38da06d6f2b397be5d8ab7fdeb169f
comaniac
comaniac approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @zhiics

@zhiics zhiics merged commit c958bc1 into apache:master Aug 27, 2020
@zhiics
Copy link
Member

zhiics commented Aug 27, 2020

Thanks @lhutton1 @comaniac

kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
@lhutton1 @kevinthesun
[BYOC][ACL] Improved pooling support (apache#6248)
0354bd9 
* [BYOC][ACL] Improved pooling support

Adds support in ACL for the following relay pooling operators and composite functions:
  * nn.avg_pool2d (fp32), cast + nn.avg_pool2d(uint8) + cast => AVG pool
  * nn.global_max_pool2d => Global MAX pool
  * nn.global_avg_pool2d, cast + nn.global_avg_pool2d(uint8) + cast => Global AVG pool
  * power(2) + nn.avg_pool2d + sqrt => L2 pooling (for fp32 only)

Tests updated to reflect these changes.

Change-Id: I1644b67b60ebb252344eb9695a521d2d958c724e

* Address comments

Change-Id: Ibe8a61b4c42da246ce54701c89ea985b423c8f83

* Fix not checking output saturation

Change-Id: Ia6f3d9db31cfb8c417d8556d29961210fea418b2

* Use defined set of trials

Change-Id: Ib180e3a0cbb84d6fa00c7e1994f58cb62662db15

* Rebase master

Change-Id: I5c932751cd38da06d6f2b397be5d8ab7fdeb169f
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
@lhutton1 @kevinthesun
[BYOC][ACL] Improved pooling support (apache#6248)
bab6148 
* [BYOC][ACL] Improved pooling support

Adds support in ACL for the following relay pooling operators and composite functions:
  * nn.avg_pool2d (fp32), cast + nn.avg_pool2d(uint8) + cast => AVG pool
  * nn.global_max_pool2d => Global MAX pool
  * nn.global_avg_pool2d, cast + nn.global_avg_pool2d(uint8) + cast => Global AVG pool
  * power(2) + nn.avg_pool2d + sqrt => L2 pooling (for fp32 only)

Tests updated to reflect these changes.

Change-Id: I1644b67b60ebb252344eb9695a521d2d958c724e

* Address comments

Change-Id: Ibe8a61b4c42da246ce54701c89ea985b423c8f83

* Fix not checking output saturation

Change-Id: Ia6f3d9db31cfb8c417d8556d29961210fea418b2

* Use defined set of trials

Change-Id: Ib180e3a0cbb84d6fa00c7e1994f58cb62662db15

* Rebase master

Change-Id: I5c932751cd38da06d6f2b397be5d8ab7fdeb169f
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
@lhutton1 @trevor-m
[BYOC][ACL] Improved pooling support (apache#6248)
6e18230 
* [BYOC][ACL] Improved pooling support

Adds support in ACL for the following relay pooling operators and composite functions:
  * nn.avg_pool2d (fp32), cast + nn.avg_pool2d(uint8) + cast => AVG pool
  * nn.global_max_pool2d => Global MAX pool
  * nn.global_avg_pool2d, cast + nn.global_avg_pool2d(uint8) + cast => Global AVG pool
  * power(2) + nn.avg_pool2d + sqrt => L2 pooling (for fp32 only)

Tests updated to reflect these changes.

Change-Id: I1644b67b60ebb252344eb9695a521d2d958c724e

* Address comments

Change-Id: Ibe8a61b4c42da246ce54701c89ea985b423c8f83

* Fix not checking output saturation

Change-Id: Ia6f3d9db31cfb8c417d8556d29961210fea418b2

* Use defined set of trials

Change-Id: Ib180e3a0cbb84d6fa00c7e1994f58cb62662db15

* Rebase master

Change-Id: I5c932751cd38da06d6f2b397be5d8ab7fdeb169f
@lhutton1 lhutton1 deleted the acl-pooling-improvement branch September 23, 2020 10:27
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiics zhiics zhiics approved these changes

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhutton1 @zhiics @comaniac @ZihengJiang