-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] Initial support for Hexagon codegen #6261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief review the codegen part, will spend more time next monday. One quick question, does this support HVX vector instruction generated?
This commit does not support parallel execution or prefetch. LLVM 7 or later is required.
HVX instructions are generated either by auto-vectorizing loops in LLVM, or by using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Some comments are listed as following
Thanks @kparzysz-quic merged. Wish we could do follow up work (code gen parallel and prefetch) and write one document how to deploy on hexagon. |
The reasons why prefetch and parallel are not supported in this PR are:
We wanted to get some basic Hexagon codegen working first, hence this PR. We definitely plan to address the issues I mentioned above, it will just happen later. |
* [Hexagon] Initial support for Hexagon codegen This commit does not support parallel execution or prefetch. LLVM 7 or later is required. * Set native_vector_bits_ based on target features * Initialize hvx_bytes * Remove commented out line
* [Hexagon] Initial support for Hexagon codegen This commit does not support parallel execution or prefetch. LLVM 7 or later is required. * Set native_vector_bits_ based on target features * Initialize hvx_bytes * Remove commented out line
* [Hexagon] Initial support for Hexagon codegen This commit does not support parallel execution or prefetch. LLVM 7 or later is required. * Set native_vector_bits_ based on target features * Initialize hvx_bytes * Remove commented out line
* [Hexagon] Initial support for Hexagon codegen This commit does not support parallel execution or prefetch. LLVM 7 or later is required. * Set native_vector_bits_ based on target features * Initialize hvx_bytes * Remove commented out line
* [Hexagon] Initial support for Hexagon codegen This commit does not support parallel execution or prefetch. LLVM 7 or later is required. * Set native_vector_bits_ based on target features * Initialize hvx_bytes * Remove commented out line
This commit does not support parallel execution or prefetch.