Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parser] Add support for parsing the any dimension. #6277

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

jroesch
Copy link
Member

@jroesch jroesch commented Aug 14, 2020

This adds support for parsing the any dimension to the Relay parser, this was not taken care of in the existing test suite so we ensure that any dimensions are in fact parseable.

cc @chanwutk this should fix your issue
cc @mbrookhart
cc @zhiics

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit 4b2c01a into apache:master Aug 14, 2020
@chanwutk
Copy link

Thank you!

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* Add case for any dimensions

* Fix second test case
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* Add case for any dimensions

* Fix second test case
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* Add case for any dimensions

* Fix second test case
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
* Add case for any dimensions

* Fix second test case
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
* Add case for any dimensions

* Fix second test case
@jroesch jroesch deleted the parse-any-dim branch February 4, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants