Improve error messages for memory verifier and gpu memory verifier #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully we can port this to diagnostics when we get there. |
jroesch
approved these changes
Aug 14, 2020
|
LGTM, cc @junrushao1994 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6281) * [FIX] Print exactly what issues the GPU memory verifier encountered. * [FIX] Print exactly why memory verifier failed.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6281) * [FIX] Print exactly what issues the GPU memory verifier encountered. * [FIX] Print exactly why memory verifier failed.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6281) * [FIX] Print exactly what issues the GPU memory verifier encountered. * [FIX] Print exactly why memory verifier failed.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…pache#6281) * [FIX] Print exactly what issues the GPU memory verifier encountered. * [FIX] Print exactly why memory verifier failed.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…pache#6281) * [FIX] Print exactly what issues the GPU memory verifier encountered. * [FIX] Print exactly why memory verifier failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the TIR analysis passes memory verifier and gpu memory verifier to print the actual error they encountered. Previous they just printed a generic error message.