[RELAY][DYN] Implementation of the dynamic pad operator #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
requested changes
Aug 17, 2020
There was a problem hiding this comment.
This appears to have #6273 in it as well. Can you separate the upsampling work?
|
@zhiics @icemelon9 @mbrookhart had a few bugs on this, but it's good to go now! Please let me know what you think. Thanks |
mbrookhart
approved these changes
Aug 18, 2020
python/tvm/relay/op/nn/nn.py
Outdated
| @@ -1147,13 +1149,13 @@ def upsampling(data, | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| data : tvm.relay.Expr | |||
| data : tvm.relay.Expr or tuple<anytype> or list<anytype> | |||
There was a problem hiding this comment.
I don't think data can be a tuple or list?
tqchen
approved these changes
Aug 20, 2020
|
Thanks @mbrookhart @electriclilies ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the dynamic pad operator
@mbrookhart @zhiics please take a look and let me know if you have any suggestions
Also, clang-format changed a bunch of stuff in include/tvm/relay/attrs/nn.h -- what files are supposed to be formatted using clang-format?