Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend][Relay] Fix node indices attribute error for tensorflow 2.3 #6288

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

iswariyam
Copy link
Contributor

The Node class Tensorflow 2.3 no longer has the attributes node_indices and tensor_indices as explained in #6287. However, the values of these attributes can be obtained using iterate_inbound. Using this method also allows relay.frontend.from_keras() to be backward compatible with previous tensorflow versions.

Closes #6287

@iswariyam
Copy link
Contributor Author

Please review @srkreddy1238 @yongwww @jwfromm

@tqchen tqchen merged commit f6e00a0 into apache:master Aug 17, 2020
@tqchen
Copy link
Member

tqchen commented Aug 17, 2020

Thanks @iswariyam !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…apache#6288)

* Fix errors caused due to node attributes

* Add node_indices attr for old keras pkg support
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…apache#6288)

* Fix errors caused due to node attributes

* Add node_indices attr for old keras pkg support
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
…apache#6288)

* Fix errors caused due to node attributes

* Add node_indices attr for old keras pkg support
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
…apache#6288)

* Fix errors caused due to node attributes

* Add node_indices attr for old keras pkg support
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
…apache#6288)

* Fix errors caused due to node attributes

* Add node_indices attr for old keras pkg support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TVMError: relay.frontend.from_keras() fails with models compiled in tensorflow 2.3
2 participants