[DYN][RELAY] Resize support for NCHW-convertible layouts #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
approved these changes
Aug 18, 2020
icemelon
reviewed
Aug 24, 2020
| out = [_NCHW_resize_shape_func(inputs[0].shape, inputs[1], convert(len(inputs[0].shape)))] | ||
| if nchw_pack_layout(layout) or nchw_xc_layout(layout): | ||
| out = [_resize_shape_func(inputs[0].shape, inputs[1], convert(len(inputs[0].shape)), | ||
| convert(2), convert(3), convert(1))] |
There was a problem hiding this comment.
Does the shape function work for NCHWc layout?
There was a problem hiding this comment.
It should. The shape function copies the entire shape by iterating over ndim, so all dimensions are copied before any swapping happens.
There was a problem hiding this comment.
I see.
btw. why do we need out[channel_axis] = int64(dshape[channel_axis]) since it's already copied?
There was a problem hiding this comment.
I guess it is redundant, I will remove it
jroesch
approved these changes
Aug 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* fix lint * fix typo * remove channel_axis from resize shape func * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* fix lint * fix typo * remove channel_axis from resize shape func * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* fix lint * fix typo * remove channel_axis from resize shape func * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* fix lint * fix typo * remove channel_axis from resize shape func * fix lint
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* fix lint * fix typo * remove channel_axis from resize shape func * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icemelon9 pointed out that we can support more layouts than just NCHW and NHWC in shape functions for resize and upsampling. This PR adds support for NCHW convertible layouts to resize's shape function.
cc @mbrookhart @zhiics