[Relay] Make check stricter: disallow inserting function with free vars into module. #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. If there is no specific reason, we should make the check as restrictive and possible to make sure we fail early. I was wondering why it was just a warning before? Any specific reasons? |
|
@junrushao1994 ppl was adding graph to irmodule. i add check to make it warning but tq say we should wait for a big version to make them error. |
|
I see. I am for this particular change. Also @tqchen what do you think? |
|
Looks like it cannot pass CI because there are some test cases that free variables exist... |
|
Creating a function and binding those free vars should fix some of the failing tests? |
MarisaKirisame
force-pushed
the
stricter-check
branch
from
805bbc8
to
b3ccdbe
Compare
|
@zhiics @junrushao1994 the CI now pass. care to give some review? |
zhiics
approved these changes
Aug 22, 2020
|
Thanks for the discussion today! |
junrushao
approved these changes
Aug 22, 2020
|
Thanks @MarisaKirisame @junrushao1994 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…rs into module. (apache#6313) * save lint lint fix test fix test * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…rs into module. (apache#6313) * save lint lint fix test fix test * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…rs into module. (apache#6313) * save lint lint fix test fix test * fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…rs into module. (apache#6313) * save lint lint fix test fix test * fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…rs into module. (apache#6313) * save lint lint fix test fix test * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was warning, but it had been the source of many bug in developing. This will check those bugs as soon as possible.
@jroesch @zhiics @junrushao1994 can you guys review?