[TIR] Enforce buffer pointer var type to be consistent with dtype. #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have type_annotation in tir::Var. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows future passes to directly use the content type information via type_annotation. This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate. A follow up PR need to fix a few more cases in the hybrid script parsing before everything can be made consistent.
spectrometerHBH
approved these changes
Aug 21, 2020
junrushao
reviewed
Aug 21, 2020
| @@ -263,6 +263,9 @@ TVM_STATIC_IR_FUNCTOR(ReprPrinter, vtable) | |||
| // Allocate | |||
| Allocate::Allocate(Var buffer_var, DataType dtype, Array<PrimExpr> extents, PrimExpr condition, | |||
| Stmt body) { | |||
| // TODO(tvm-team): Add invariant check to make sure | |||
| // IsPointerPType(buffer_var->type_annotation, dtype) | |||
| // once we fix the allocate hybrid script printing. | |||
There was a problem hiding this comment.
Will it be addressed soon in a follow-up PR for hybrid script?
There was a problem hiding this comment.
yes, i believe we can send another PR once the hybrid script printing part is fixed.
junrushao
approved these changes
Aug 21, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6317) Now that we have type_annotation in tir::Var. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows future passes to directly use the content type information via type_annotation. This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate. A follow up PR need to fix a few more cases in the hybrid script parsing before everything can be made consistent.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6317) Now that we have type_annotation in tir::Var. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows future passes to directly use the content type information via type_annotation. This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate. A follow up PR need to fix a few more cases in the hybrid script parsing before everything can be made consistent.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…pache#6317) Now that we have type_annotation in tir::Var. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows future passes to directly use the content type information via type_annotation. This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate. A follow up PR need to fix a few more cases in the hybrid script parsing before everything can be made consistent.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…pache#6317) Now that we have type_annotation in tir::Var. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows future passes to directly use the content type information via type_annotation. This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate. A follow up PR need to fix a few more cases in the hybrid script parsing before everything can be made consistent.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…pache#6317) Now that we have type_annotation in tir::Var. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows future passes to directly use the content type information via type_annotation. This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate. A follow up PR need to fix a few more cases in the hybrid script parsing before everything can be made consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have type_annotation in
tir::Var.We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation.
This change allows future passes to directly use the content type information via type_annotation.
This PR turns on the enforcement on Buffer and also fixed a few cases for Allocate.
A follow up PR need to fix a few more cases in the hybrid script parsing
before everything can be made consistent.